Skip to content

Commit

Permalink
Change "Run query" button to "Run queries" and release 0.3.2 (#77)
Browse files Browse the repository at this point in the history
  • Loading branch information
idastambuk authored Feb 21, 2024
1 parent 619ea43 commit 0202814
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
All notable changes to this project will be documented in this file.


## v0.3.2

- Change "Run query" button to "Run queries" im [#77](https://github.com/grafana/grafana-aws-sdk-react/pull/77)

## v0.3.1

- Add spellcheck script and drone step in [#67](https://github.com/grafana/grafana-aws-sdk-react/pull/67)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grafana/aws-sdk",
"version": "0.3.1",
"version": "0.3.2",
"description": "Common AWS features for grafana",
"main": "dist/index.js",
"module": "dist/esm/index.js",
Expand Down
8 changes: 4 additions & 4 deletions src/sql/QueryEditor/QueryEditorHeader.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ describe('QueryEditorHeader', () => {
});
it('should display just the run button if showAsyncQueryButtons prop is false', async () => {
render(<QueryEditorHeader {...props} showAsyncQueryButtons={false} />);
const runButton = screen.getByRole('button', { name: 'Run query' });
const runButton = screen.getByRole('button', { name: 'Run queries' });
const stopButton = screen.queryByRole('button', { name: 'Stop query' });
expect(runButton).toBeInTheDocument();
expect(stopButton).not.toBeInTheDocument();
});

it('run button should be disabled if enableButton prop is false', () => {
render(<QueryEditorHeader {...props} enableRunButton={false} showAsyncQueryButtons={false} />);
const runButton = screen.getByRole('button', { name: 'Run query' });
const runButton = screen.getByRole('button', { name: 'Run queries' });
expect(runButton).toBeDisabled();
});

Expand All @@ -43,7 +43,7 @@ describe('QueryEditorHeader', () => {
showAsyncQueryButtons={false}
/>
);
const runButton = screen.getByRole('button', { name: 'Run query' });
const runButton = screen.getByRole('button', { name: 'Run queries' });
expect(runButton).toBeDisabled();
});

Expand All @@ -52,7 +52,7 @@ describe('QueryEditorHeader', () => {
render(
<QueryEditorHeader {...props} onRunQuery={onRunQuery} showAsyncQueryButtons={false} enableRunButton={true} />
);
const runButton = screen.getByRole('button', { name: 'Run query' });
const runButton = screen.getByRole('button', { name: 'Run queries' });
expect(runButton).toBeInTheDocument();
fireEvent.click(runButton);
expect(onRunQuery).toBeCalledTimes(1);
Expand Down
2 changes: 1 addition & 1 deletion src/sql/QueryEditor/QueryEditorHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function QueryEditorHeader<
icon={data?.state === LoadingState.Loading ? 'fa fa-spinner' : undefined}
disabled={data?.state === LoadingState.Loading || !enableRunButton}
>
Run query
Run queries
</Button>
)}
{extraHeaderElementRight}
Expand Down

0 comments on commit 0202814

Please sign in to comment.