Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restart config from docker-compose #94

Closed
wants to merge 1 commit into from

Conversation

SandersAaronD
Copy link
Collaborator

This should fix some build problems we see where images persist after docker-compose is killed and has very little downside, if any.

Copy link
Contributor

@manderson-dev manderson-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purged my containers/images/volumes and pulled down this branch and ran 'make docker' and got the same issue:

Attaching to ai-training-api-1, db-1, loki-1, mimir-1, pyroscope-1, tempo-1, grafana-with-training-app
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: Ports are not available: exposing port TCP 0.0.0.0:4040 -> 0.0.0.0:0: listen tcp 0.0.0.0:4040: bind: address already in use
make: *** [docker] Error 1

I can progress past the issue by restarting the grafana-with-training-app and the pyroscope-1 containers. They start up fine when restarting them and then localhost works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants