remove not needed IndexStreamException

gpslab · Jun 14, 2019 · 656a7a8 · 656a7a8
1 parent 6128dd9
commit 656a7a8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 53 deletions.
diff --git a/src/Stream/Exception/FileAccessException.php b/src/Stream/Exception/FileAccessException.php
@@ -37,7 +37,7 @@ final public static function notReadable($filename)
      *
      * @return self
      */
-    public static function failedOverwrite($tmp_filename, $target_filename)
+    final public static function failedOverwrite($tmp_filename, $target_filename)
     {
         return new self(sprintf(
             'Failed to overwrite file "%s" from temporary file "%s".',

diff --git a/src/Stream/Exception/IndexStreamException.php b/src/Stream/Exception/IndexStreamException.php
diff --git a/src/Stream/RenderIndexFileStream.php b/src/Stream/RenderIndexFileStream.php
@@ -11,7 +11,6 @@
 
 use GpsLab\Component\Sitemap\Render\SitemapIndexRender;
 use GpsLab\Component\Sitemap\Stream\Exception\FileAccessException;
-use GpsLab\Component\Sitemap\Stream\Exception\IndexStreamException;
 use GpsLab\Component\Sitemap\Stream\Exception\OverflowException;
 use GpsLab\Component\Sitemap\Stream\Exception\StreamStateException;
 use GpsLab\Component\Sitemap\Stream\State\StreamState;
@@ -170,7 +169,7 @@ private function addSubStreamFileToIndex()
         // rename sitemap file to sitemap part
         $new_filename = sys_get_temp_dir().'/'.$indexed_filename;
         if (!rename($filename, $new_filename)) {
-            throw IndexStreamException::failedRename($filename, $new_filename);
+            throw FileAccessException::failedOverwrite($filename, $new_filename);
         }
 
         fwrite($this->handle, $this->render->sitemap($indexed_filename, $last_mod));
@@ -212,7 +211,7 @@ private function moveParts()
             $source = sys_get_temp_dir().'/'.$indexed_filename;
             $target = dirname($this->filename).'/'.$indexed_filename;
             if (!rename($source, $target)) {
-                throw IndexStreamException::failedRename($source, $target);
+                throw FileAccessException::failedOverwrite($source, $target);
             }
         }
     }

diff --git a/tests/Stream/Exception/IndexStreamExceptionTest.php b/tests/Stream/Exception/IndexStreamExceptionTest.php