Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: factorization machines diverged #743

Merged
merged 2 commits into from
Jul 29, 2023
Merged

fix: factorization machines diverged #743

merged 2 commits into from
Jul 29, 2023

Conversation

zhenghaoz
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.10% ⚠️

Comparison is base (e3e44b1) 70.12% compared to head (941d1cf) 70.03%.

❗ Current head 941d1cf differs from pull request most recent head 5dc9ef6. Consider uploading reports for the commit 5dc9ef6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   70.12%   70.03%   -0.10%     
==========================================
  Files          64       64              
  Lines       12166    12186      +20     
==========================================
+ Hits         8532     8535       +3     
- Misses       2854     2868      +14     
- Partials      780      783       +3     
Files Changed Coverage Δ
base/progress/progress.go 0.00% <0.00%> (ø)
storage/cache/mongodb.go 80.46% <0.00%> (-0.54%) ⬇️
master/tasks.go 59.36% <33.33%> (-0.11%) ⬇️
model/click/model.go 78.47% <62.50%> (-0.46%) ⬇️
model/ranking/model.go 81.70% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhenghaoz zhenghaoz marked this pull request as ready for review July 29, 2023 09:30
@zhenghaoz zhenghaoz merged commit 59ab0b4 into master Jul 29, 2023
6 checks passed
@zhenghaoz zhenghaoz deleted the diverge branch July 29, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant