Support ispx with generics #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
commented
Aug 28, 2024
| @@ -112,7 +112,6 @@ type Spriter interface { | |||
| } | |||
| type Gamer interface { | |||
| initGame(sprites []Spriter) *Game | |||
| getGame() *Game | |||
There was a problem hiding this comment.
For now we need to maintain the same interface Gamer in ispx to make it work in browser, see details in https://github.com/goplus/builder/blob/35c6e0883c5c66b29eaeed2bf99d0731f06774f9/tools/ispx/main.go#L74-L76
It is better to keep Gamer as simple as possible.
We defined another interface ShapeGetter to implement getWidget. ShapeGetter is implemented by both *Game & *Sprite.
JiepengTan
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update goplus/builder#765
We simplified function body of
Gopt_Game_Gopx_GetWidgetin this PR to make it easy for ispx to support generics. See detials in goplus/builder#765 (comment)Related change in Builder: goplus/builder#767