featWASM Compiler: get struct field & method into completion item.
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
callme-taota
commented
Sep 14, 2024
callme-taota
commented
|
Hi @callme-taota. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nighca 补全结构体字段的PR，帮忙看看~ |
nighca
approved these changes
Sep 14, 2024
| selector, find := getSelector(file, cursorPos) | ||
| if find { | ||
| selectorInfoGetter(info, selector, items) | ||
| if items != nil { |
There was a problem hiding this comment.
Nit: 这里 items 好像一定不会是 nil？
There was a problem hiding this comment.
另外现在这个函数叫 getScopesItems 其实已经不太合适了，因为它产生的 completion item 不一定是从 scope 来，可以考虑就叫 getCompletionItems
There was a problem hiding this comment.
好的好的，马上补一个修复的pr
callme-taota
added a commit
to callme-taota/builder
that referenced
this pull request
Sep 19, 2024
…oplus#913) * feat: get struct field & method into completion item . * fix: fix the bug of wrong if statements.
nighca
pushed a commit
that referenced
this pull request
Sep 20, 2024
* feat: fill the document. * feat`WASM Compiler`: get struct field & method into completion item. (#913) * feat: get struct field & method into completion item . * fix: fix the bug of wrong if statements. * refactor(spx): inputAssistant Provider will filter Token effect in different code page (#911) * feat: add animation in sidebar, refactor sidebar inputAssistant to show whole categories * feat: filter inputAssistant item in different code page * refactor: rename some vue ref element variable name * refactor: refactor tokens property sample, refactor inputAssistant will not merge wasm usages. * fix: fix some tokens sample * refactor: refactor `usageEffect2Icon` into 2 functions, add `definitionStructName2Target` to transform wasm definition into TokenUsage Target * feat(spx-gui): implement audio preview (#908) * feat: implement audio preview * feat: complete audio player event ,audio player wave bar has different performance in playing * fix: rename `getScopesItems` -> `getCompletionItems`. (#916) fix: fix wrong if statement. * feat(spx-gui): completion menu doc (#917) * feat: completion menu document * refactor: refactor CompletionItem props undefined * refactor: update completion menu doc css animation and method `getCompletionItemByIdx` * docs: add necessary comment in completion menu item * refactor(spx-gui): refactor Audio player props (#918) * refactor: refactor `AudioPreview.vue` props into `File` and update related types * fix: fix `PreprocessModal.vue` component css style variable incorrect using * fix: fix `File` class related by using reactive ts type mismatch error * feat: add some document. --------- Co-authored-by: molinla <61045398+molinla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.