Skip to content

Commit

Permalink
Firestore: Remove obsolete special case from tests when verifying "mi…
Browse files Browse the repository at this point in the history
…ssing index" error message in non-default DB
  • Loading branch information
dconeybe committed Jan 8, 2024
1 parent 3060e86 commit 10f1714
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1101,10 +1101,6 @@ public void aggregateQueryShouldFailWithMessageWithConsoleLinkIfMissingIndex() {

Throwable throwable = executionException.getCause();
assertThat(throwable).hasMessageThat().ignoringCase().contains("index");
// TODO(b/316359394) Remove this check for the default databases once cl/582465034 is rolled out
// to production.
if (collection.getFirestore().getOptions().getDatabaseId().equals("(default)")) {
assertThat(throwable).hasMessageThat().contains("https://console.firebase.google.com");
}
assertThat(throwable).hasMessageThat().contains("https://console.firebase.google.com");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -386,11 +386,7 @@ public void countQueryShouldFailWithMessageWithConsoleLinkIfMissingIndex() {

Throwable throwable = executionException.getCause();
assertThat(throwable).hasMessageThat().ignoringCase().contains("index");
// TODO(b/316359394) Remove this check for the default databases once cl/582465034 is rolled out
// to production.
if (collection.getFirestore().getOptions().getDatabaseId().equals("(default)")) {
assertThat(throwable).hasMessageThat().contains("https://console.firebase.google.com");
}
assertThat(throwable).hasMessageThat().contains("https://console.firebase.google.com");
}

private CollectionReference createEmptyCollection() {
Expand Down

0 comments on commit 10f1714

Please sign in to comment.