Skip to content

Commit

Permalink
Fix a bug with summary reporting
Browse files Browse the repository at this point in the history
If we had an analysis failure, we'd sometimes report success.
  • Loading branch information
rictic committed Aug 27, 2023
1 parent 60908dd commit 0056c0a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/logging/quiet-logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ class RunTracker {
* The number of scripts that finished with errors.
*/
private _failed = 0;
private _encounteredFailures = false;
private _servicesRunning = 0;
private _analysisInfo: AnalysisInfo | undefined = undefined;
private _state: 'initial' | 'analyzing' | 'running' | 'analysis failed' =
Expand Down Expand Up @@ -330,7 +331,7 @@ class RunTracker {
}
scriptsStillRunning = true;
}
if (this._failed > 0 || scriptsStillRunning) {
if (this._encounteredFailures || scriptsStillRunning) {
this._printFailureSummary();
return;
}
Expand Down Expand Up @@ -561,6 +562,7 @@ class RunTracker {
)}`
);
}
this._encounteredFailures = true;
{
using _pause = this._writeoverLine.clearUntilDisposed();
this._reportFailure(event);
Expand Down

0 comments on commit 0056c0a

Please sign in to comment.