Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Go controller comment #280

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

duffn
Copy link
Contributor

@duffn duffn commented Jul 20, 2024

This adds the controller comment to the Go library. EnableController was already available on the configuration, but it was not added to the SQL comments.

Closes #279

Copy link

google-cla bot commented Jul 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@sjs994 sjs994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjs994 sjs994 merged commit 871c1c8 into google:master Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Go library does not comment controller
2 participants