Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to set descriptor set and binding of default uniform block #1437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akaricchi
Copy link

This is for the relaxed Vulkan rules mode.

Copy link

google-cla bot commented Jul 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Please sign the CLA.

Please add a command line option for glslc, and add tests for the C++ API and the glslc command line.

@Akaricchi
Copy link
Author

I have signed the CLA, see here: https://github.com/google/shaderc/pull/1437/checks?check_run_id=27778572097

I don't know why the bot's comment is still up.

I'll see about adding the tests and CLI tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants