Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Apple docs link for global proxy settings constants #1367

Merged
merged 5 commits into from
Jun 18, 2024
+4 −3
Merged

Use new Apple docs link for global proxy settings constants #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b090089
Use new Apple docs link for global proxy settings constants
mlw Jun 18, 2024
4f14a40
Missed a file...
mlw Jun 18, 2024
14afc42
WIP test workflow change
mlw Jun 18, 2024
8e80642
WIP Fix link
mlw Jun 18, 2024
91bd319
Remove trailing whitespace
mlw Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/check-markdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ jobs:
with:
fail: true
- name: "Check for trailing whitespace and newlines"
if: '!cancelled()'
run: "! git grep -EIn $'[ \t]+$' -- ':(exclude)*.patch'"
2 changes: 1 addition & 1 deletion Source/common/SNTConfigurator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@
/// Proxy settings for syncing.
/// This dictionary is passed directly to NSURLSession. The allowed keys
/// are loosely documented at
/// https://developer.apple.com/documentation/cfnetwork/global_proxy_settings_constants.
/// https://developer.apple.com/documentation/cfnetwork/global-proxy-settings-constants.
///
@property(readonly, nonatomic) NSDictionary *syncProxyConfig;

Expand Down
2 changes: 1 addition & 1 deletion docs/deployment/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ also known as mobileconfig files, which are in an Apple-specific XML format.
| ModeNotificationLockdown | String | The notification text to display when the client goes into Lockdown mode. Defaults to "Switching into Lockdown mode". |
| SyncBaseURL | String | The base URL of the sync server. |
| SyncEnableProtoTransfer | Bool | If true, sync will happen using binary protos instead of JSON. Defaults to false. |
| SyncProxyConfiguration | Dictionary | The proxy configuration to use when syncing. See the [Apple Documentation](https://developer.apple.com/documentation/cfnetwork/global_proxy_settings_constants) for details on the keys that can be used in this dictionary. |
| SyncProxyConfiguration | Dictionary | The proxy configuration to use when syncing. See the [Apple Documentation](https://developer.apple.com/documentation/cfnetwork/global-proxy-settings-constants) for details on the keys that can be used in this dictionary. |
| SyncEnableCleanSyncEventUpload | Bool | If true, events will be uploaded to the sync server even if a clean sync is requested. Defaults to false. |
| ClientAuthCertificateFile | String | If set, this contains the location of a PKCS#12 certificate to be used for sync authentication. |
| ClientAuthCertificatePassword | String | Contains the password for the PKCS#12 certificate. |
Expand Down
2 changes: 1 addition & 1 deletion docs/development/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ All submissions related to the use of different identifiers should adhere to the
| Identifier | Notes | Example |
| -------- | ------- | ------- |
| SHA-256 | lowercase | `801d1dd8bc78984c126a269aca053642d16eef4389dfdc8df575af929fdcf279` |
| CDHash | lowercase | `2d1cff4b1080058e7e5913e5a3398bcd0199b6a4` |
| CDHash | lowercase | `2d1cff4b1080058e7e5913e5a3398bcd0199b6a4` |
| TeamID | uppercase | `43AQ936H96` |
| Signing ID | case insensitive | `EQHXZ8M8AV:com.google.Chrome` |

Expand Down
Loading