Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc URL to profile format and use it display help link. #888

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

ghemawat
Copy link
Contributor

image

@ghemawat ghemawat requested a review from aalexand August 27, 2024 20:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (0ed6a68) to head (5b49d6c).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   66.86%   67.33%   +0.47%     
==========================================
  Files          44       44              
  Lines        9824     9822       -2     
==========================================
+ Hits         6569     6614      +45     
+ Misses       2794     2761      -33     
+ Partials      461      447      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghemawat
Copy link
Contributor Author

This is now ready to review. Changes from prior commit:

  1. Rebased to pick up Go version changes.
  2. Added a small test to cover new code.

aalexand
aalexand previously approved these changes Aug 29, 2024
proto/profile.proto Outdated Show resolved Hide resolved
@ghemawat
Copy link
Contributor Author

Will need another approval because of the comment change, sorry.

@aalexand aalexand merged commit da1f7e9 into google:main Aug 29, 2024
31 checks passed
@aalexand
Copy link
Collaborator

aalexand commented Sep 3, 2024

@ghemawat We didn't add printing the link in the pprof CLI output, right? Should we add that too? E.g. the -top output has some summary information at the beginning, perhaps we should show the link there?

@ghemawat
Copy link
Contributor Author

ghemawat commented Sep 3, 2024

@ghemawat We didn't add printing the link in the pprof CLI output, right? Should we add that too? E.g. the -top output has some summary information at the beginning, perhaps we should show the link there?

Good point. I can do that in a bit. It is less useful since it doesn't show up as a clickable link, but might as well add it.

@ghemawat ghemawat deleted the docurl branch September 3, 2024 15:05
aalexand added a commit to aalexand/opentelemetry-proto that referenced this pull request Sep 12, 2024
github.com/google/pprof/pull/888 added this field in pprof proto, this
change adds it to the OTel profiling proto to match the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants