Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.21 #3387

Closed
wants to merge 6 commits into from
Closed

Conversation

Neo2308
Copy link

@Neo2308 Neo2308 commented Aug 27, 2023

  • Use go 1.21
  • Start running tests on go 1.21
  • Stop running tests on go 1.19
  • Update setup-go action to v3
  • Update checkout action to v3 (missed from Update actions/checkout to v3 #3324)

@google-cla
Copy link

google-cla bot commented Aug 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @Neo2308. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 3, 2023

/ok-to-test

@Neo2308 Neo2308 requested a review from iwankgb September 3, 2023 11:41
@Neo2308 Neo2308 changed the title Run tests on go 1.21 Bump golang to 1.21 Sep 3, 2023
@Neo2308
Copy link
Author

Neo2308 commented Sep 28, 2023

@iwankgb I seem to have requested a review from you again by mistake, but that is now blocking the PR. Could you take a look? My apologies for the inconvenience.

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 7, 2023

@Neo2308, can you merge master, please?

@Neo2308
Copy link
Author

Neo2308 commented Oct 9, 2023

@iwankgb done ✅

@Neo2308
Copy link
Author

Neo2308 commented Oct 23, 2023

@iwankgb any pointers on what to do next?

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 29, 2023

@Neo2308, you have to set DEBIAN_FRONTEND.

* Start running tests on go 1.21
* Stop running tests on go 1.19
* Update setup-go action to v3

Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@bobbypage
Copy link
Collaborator

Bumped in #3474; Adjusted that PR to 1.22. Thanks again @Neo2308 for the help!

@bobbypage bobbypage closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants