Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AWS Go SDK v2 #3201

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Migrate to AWS Go SDK v2 #3201

merged 1 commit into from
Jul 11, 2024

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Nov 22, 2022

Version 2 of the SDK splits features across different Go modules. See
https://aws.github.io/aws-sdk-go-v2/docs/migrating/ for the migration
guide.

Signed-off-by: Stephen Kitt skitt@redhat.com

@k8s-ci-robot
Copy link
Collaborator

Hi @skitt. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Collaborator

dims commented Nov 22, 2022

@skitt landing this in cadvisor will make it hard to integrate a new version of cadvisor in kubernetes. Unless of course we have a draft PR in k8s that can do the same change in dependency in kubernetes as well. (we don't want to have 2 versions of a cloud provider library/dependency in k8s).

@skitt
Copy link
Contributor Author

skitt commented Nov 22, 2022

@skitt landing this in cadvisor will make it hard to integrate a new version of cadvisor in kubernetes. Unless of course we have a draft PR in k8s that can do the same change in dependency in kubernetes as well. (we don't want to have 2 versions of a cloud provider library/dependency in k8s).

Ah yes, good point… I’ll look into the k8s situation and report back.

@skitt
Copy link
Contributor Author

skitt commented Jan 29, 2024

@dims now that the AWS dependency is gone from K8s, this should be OK; is it?

@dims
Copy link
Collaborator

dims commented Jun 20, 2024

@dims now that the AWS dependency is gone from K8s, this should be OK; is it?

yep!

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 22, 2024

@skitt, you may need to merge master here.

@skitt
Copy link
Contributor Author

skitt commented Jun 24, 2024

@skitt, you may need to merge master here.

Done, I’ve included #3553 to be able to build locally, but I think that warrants a separate review.

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 6, 2024

You need to run go mod tidy, I believe (https://github.com/google/cadvisor/actions/runs/9747285841/job/26899619315?pr=3201)

@skitt
Copy link
Contributor Author

skitt commented Jul 7, 2024

You need to run go mod tidy, I believe (https://github.com/google/cadvisor/actions/runs/9747285841/job/26899619315?pr=3201)

I do indeed, in cmd, thanks for the reminder!

Version 2 of the SDK splits features across different Go modules. See
https://aws.github.io/aws-sdk-go-v2/docs/migrating/ for the migration
guide.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@iwankgb
Copy link
Collaborator

iwankgb commented Jul 8, 2024

/ok-to-test

@iwankgb iwankgb merged commit b1cd2b9 into google:master Jul 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants