Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OOM event count to prometheus #2829

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

kragniz
Copy link
Contributor

@kragniz kragniz commented Mar 8, 2021

Fixes #1837.

@k8s-ci-robot
Copy link
Collaborator

Hi @kragniz. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kragniz
Copy link
Contributor Author

kragniz commented Mar 8, 2021

I'm not convinced this is the best way to get the event data through, but seemed like the most straightforward. If this is an acceptable method, I can add tests and tidy this up further.

@kragniz
Copy link
Contributor Author

kragniz commented Mar 9, 2021

/assign @bobbypage

cmd/cadvisor.go Outdated Show resolved Hide resolved
manager/manager.go Outdated Show resolved Hide resolved
manager/manager.go Outdated Show resolved Hide resolved
manager/manager.go Outdated Show resolved Hide resolved
@kragniz kragniz force-pushed the prometheus-oom-count branch 2 times, most recently from b6703b4 to 0de3d6e Compare March 11, 2021 17:44
@kragniz
Copy link
Contributor Author

kragniz commented Mar 11, 2021

@iwankgb thanks for the reviews, I've updated with fixes

@iwankgb
Copy link
Collaborator

iwankgb commented Mar 11, 2021

/ok-to-test

@kragniz
Copy link
Contributor Author

kragniz commented Mar 12, 2021

/retest

@darkl0rd
Copy link

darkl0rd commented Apr 20, 2022

This metric (Docker) always returns 0 for me - see also #3015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting docker container oom event.
4 participants