notice

Signed-off-by: dsxing <xingdashuaostar@126.com>

cache/memory/memory.go

@@ -129,6 +129,10 @@ func (c *InMemoryCache) RemoveContainer(containerName string) error {
 	return nil
 }
 
+func (c *InMemoryCache) GetMaxAge() time.Duration {
+	return c.maxAge
+}
+
 func New(
 	maxAge time.Duration,
 	backend []storage.StorageDriver,

manager/container.go

@@ -47,7 +47,9 @@ import (
 
 // Housekeeping interval.
 var enableLoadReader = flag.Bool("enable_load_reader", false, "Whether to enable cpu load reader")
-var HousekeepingInterval = flag.Duration("housekeeping_interval", 1*time.Second, "Interval between container housekeepings")
+var HousekeepingInterval = flag.Duration("housekeeping_interval", 1*time.Second, "Interval between container housekeepings."+
+	" It should be less than 'max_housekeeping_interval',"+
+	" and it must be less than memory's maxAge('storage_duration'), which is set to 2 minutes by default.")
 
 // TODO: replace regular expressions with something simpler, such as strings.Split().
 // cgroup type chosen to fetch the cgroup path of a process.

manager/manager.go

@@ -175,6 +175,10 @@ func New(memoryCache *memory.InMemoryCache, sysfs sysfs.SysFs, HousekeepingConfi
 		return nil, err
 	}
 
+	if *HousekeepingInterval >= memoryCache.GetMaxAge() {
+		return nil, fmt.Errorf("invalid housekeeping_interval setting, it must be less than memory's maxAge('storage_duration'), which is set to 2 minutes by default.")
+	}
+
 	fsInfo, err := fs.NewFsInfo(context)
 	if err != nil {
 		return nil, err