Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relayed connection client becomes numb after disconnect and reconnect #310

Merged
merged 31 commits into from
Sep 19, 2023
Merged

relayed connection client becomes numb after disconnect and reconnect #310

merged 31 commits into from
Sep 19, 2023

Conversation

staszek-krotki
Copy link
Contributor

@staszek-krotki staszek-krotki commented Sep 4, 2023 •
edited
Loading

Resolves #317

@staszek-krotki staszek-krotki marked this pull request as ready for review September 13, 2023 16:01
pwalski
pwalski reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pwalski pwalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking. Feel free to ignore it.

client/src/session.rs Outdated Show resolved Hide resolved
client/src/session.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
server/src/server.rs Outdated Show resolved Hide resolved
staszek-krotki and others added 4 commits September 18, 2023 10:30
@staszek-krotki @pwalski
Update client/src/session.rs
c670cc1 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki @pwalski
Update server/src/server.rs
e8998d0 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki @pwalski
Update server/src/server.rs
8a4c916 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki @pwalski
Update server/src/server.rs
72db353 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
staszek-krotki and others added 6 commits September 18, 2023 11:54
@staszek-krotki @pwalski
Update server/src/server.rs
a343260 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki @pwalski
Update server/src/server.rs
3664db4 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki @pwalski
Update client/src/session.rs
29e92fb 
Co-authored-by: pwalski <4924911+pwalski@users.noreply.github.com>
@staszek-krotki
review upadtes
29c4611
@staszek-krotki
Merge branch 'staszekk/nat-disconnected-client' of github.com:golemfa…
ac05073 
…ctory/ya-relay into staszekk/nat-disconnected-client
@staszek-krotki
Merge branch 'main' into staszekk/nat-disconnected-client
7792d54
pwalski
pwalski approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@pwalski pwalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is not worth to wait for my PR with tests, so it could be merged to main, and I will merge main there when/if all checks will pass.

@staszek-krotki staszek-krotki merged commit 55e4259 into main Sep 19, 2023
5 checks passed
@staszek-krotki staszek-krotki deleted the staszekk/nat-disconnected-client branch September 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwalski pwalski pwalski approved these changes

@evik42 evik42 Awaiting requested review from evik42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loosing server connection should clean network view - relayed connections get messed up after reconnect
2 participants
@staszek-krotki @pwalski