Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema before saving template #37

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

nieznanysprawiciel
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel commented Mar 22, 2024

Fixes problem:

nieznanysprawiciel@nieznanysprawiciel-laptop-Leopard-9SCXR:~/Repos/Golem/yagna/workdir/certs$ golem-certificate-cli self-sign-certificate root-cert-independent-chain.cert root-cert-independent-chain.key 
Error: Unknown json structure, missing $schema property

save_json_with_extension(key_pair_path, &key_pair.public_key, "pub")?;
save_json_with_extension(key_pair_path, &key_pair.private_key, "key")
save_json_with_extension(key_pair_path, &key_pair.public_key, "pub.json")?;
save_json_with_extension(key_pair_path, &key_pair.private_key, "key.json")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought we missed Result

Copy link
Contributor

@pwalski pwalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nieznanysprawiciel nieznanysprawiciel merged commit a542ad3 into main Mar 25, 2024
3 checks passed
@nieznanysprawiciel nieznanysprawiciel deleted the fix-ui-lacking-schema branch March 25, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants