Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the if statement in makefile which is not work on the concent-builder server #234

Conversation

bartoszbetka
Copy link
Contributor

No description provided.

@bartoszbetka bartoszbetka requested review from cameel and a user September 14, 2018 13:00
if [[ '$*' == 'control' ]]; then \
echo "initialize_django_admin: true" >> "$@"; \
if [ '$*' = 'control' ]; then\
echo "initialize_django_admin: true" >> "$@";\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the whitespace before the \. See Code-Poets/coding-style#16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but please restore the whitespace.

@bartoszbetka bartoszbetka force-pushed the bugfix-change-if-statement-in-makefile-which-is-not-work-on-the-concent-builder-server branch from 52cc529 to af88edc Compare September 14, 2018 14:08
@bartoszbetka bartoszbetka merged commit af88edc into master Sep 14, 2018
@bartoszbetka bartoszbetka deleted the bugfix-change-if-statement-in-makefile-which-is-not-work-on-the-concent-builder-server branch September 14, 2018 14:17
@cameel cameel added this to the 0.8.1 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants