-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer minimum Gleam version #3557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heya! I've not looked at the code yet but here's my thoughts on the Qs:
|
giacomocavalieri
force-pushed
the
fix-3492
branch
from
August 24, 2024 11:46
ca10751
to
61057fb
Compare
giacomocavalieri
force-pushed
the
fix-3492
branch
2 times, most recently
from
September 7, 2024 14:24
894f018
to
9c5f38a
Compare
giacomocavalieri
force-pushed
the
fix-3492
branch
from
September 8, 2024 18:09
a8a06d0
to
6e3a287
Compare
giacomocavalieri
force-pushed
the
fix-3492
branch
from
September 9, 2024 12:47
5244518
to
bd26162
Compare
lpil
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work as per usual!!!! 💜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3492
It's still a WIP because I have some questions before I can move forward:
Version
type that comes fromhexpm::version
, should we use our own minimal custom type instead of relying on this one?gleam.toml
has1.2
but we inferred the minimum one to be1.5
) how should the error be presented to the user?Do we want the error message to include an example of a usage of a feature that explains why we inferred that number? For example something that looks like this:
error: invalid Gleam version 1 | tuple.0.1 ^^^^ Nested tuple access requires a Gleam version >= 1.2 but the version specified in your `gleam.toml` is 1.1!
gleam.toml
doesn't specify any gleam version? Do we want to manually add the constraint when publishing it or have an error and force the programmer to explicitly write the inferred version down? Is there any downside to doing it implicitly?