Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilotage : Utilisation de None plutôt qu'une fausse valeur afin de corriger la synchro #4488

Merged

Conversation

rsebille
Copy link
Contributor

@rsebille rsebille commented Jul 31, 2024

🤔 Pourquoi ?

Depuis 4818e8e la fonction get_choices() n'autorise plus les valeurs non connues, mais NULL semble pouvoir très bien faire le boulot pour le pilotage donc utilisons cela

PR d'adaptation coté pilotage : gip-inclusion/pilotage-airflow#344

🏝️ Comment tester

$ ./manage.py populate_metabase_emplois --mode organizations

Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est dommage que ce soit non testé 🙈

@rsebille rsebille force-pushed the rsebille/c2/fix-syncho-for-prescriber-without-organization branch from 0cb6890 to a92024d Compare July 31, 2024 10:01
@rsebille
Copy link
Contributor Author

@tonial Tellement l'habitude que cette partie soit non testée que j´ai pas regardé mais en fait il y en a pour populate_metabase_emplois sauf pour (au moins) les organisations 😅.

@rsebille rsebille added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit d5cbd90 Aug 1, 2024
11 checks passed
@rsebille rsebille deleted the rsebille/c2/fix-syncho-for-prescriber-without-organization branch August 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants