-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add test to isAllowedConventionTransition
- Loading branch information
Showing
3 changed files
with
99 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { | ||
| ConventionReadDto, | ||
| ConventionStatus, | ||
| Role, | ||
| statusTransitionConfigs, | ||
| } from "shared"; | ||
|
|
||
| export const isAllowedConventionTransition = ( | ||
| convention: ConventionReadDto, | ||
| targetStatus: ConventionStatus, | ||
| actingRoles: Role[], | ||
| ): boolean => { | ||
| const transitionConfig = statusTransitionConfigs[targetStatus]; | ||
|
|
||
| return ( | ||
| transitionConfig.validInitialStatuses.includes(convention.status) && | ||
| actingRoles.some((actingRole) => | ||
| transitionConfig.validRoles.includes(actingRole), | ||
| ) && | ||
| (!transitionConfig.refine?.(convention).isError ?? true) | ||
| ); | ||
| }; |
62 changes: 62 additions & 0 deletions
62
front/src/app/utils/IsAllowedConventionTransition.unit.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { | ||
| ConventionDtoBuilder, | ||
| ConventionReadDto, | ||
| ConventionStatus, | ||
| Role, | ||
| } from "shared"; | ||
| import { isAllowedConventionTransition } from "src/app/utils/IsAllowedConventionTransition"; | ||
|
|
||
| const convention: ConventionReadDto = { | ||
| ...new ConventionDtoBuilder().withStatus("IN_REVIEW").build(), | ||
| agencyKind: "cap-emploi", | ||
| agencySiret: "11112222333300", | ||
| agencyCounsellorEmails: ["counsellor@mail.com"], | ||
| agencyValidatorEmails: ["validator@mail.com"], | ||
| agencyName: "Agence de cap emploi", | ||
| agencyDepartment: "75", | ||
| }; | ||
|
|
||
| type TestCase = { | ||
| convention: ConventionReadDto; | ||
| targetStatus: ConventionStatus; | ||
| roles: Role[]; | ||
| expected: boolean; | ||
| }; | ||
|
|
||
| const cases: TestCase[] = [ | ||
| { | ||
| convention, | ||
| targetStatus: "ACCEPTED_BY_COUNSELLOR", | ||
| roles: ["counsellor"], | ||
| expected: true, | ||
| }, | ||
| { | ||
| convention, | ||
| targetStatus: "ACCEPTED_BY_VALIDATOR", | ||
| roles: ["beneficiary"], | ||
| expected: false, | ||
| }, | ||
| { | ||
| convention, | ||
| targetStatus: "ACCEPTED_BY_VALIDATOR", | ||
| roles: ["counsellor"], | ||
| expected: false, | ||
| }, | ||
| { | ||
| convention, | ||
| targetStatus: "ACCEPTED_BY_VALIDATOR", | ||
| roles: ["validator"], | ||
| expected: false, | ||
| }, | ||
| ]; | ||
|
|
||
| describe("isAllowedTransition", () => { | ||
| it.each(cases)( | ||
| `Transition allowed should be $expected. With roles $roles, and target status: $targetStatus, from status ${convention.status}`, | ||
| ({ convention, targetStatus, roles, expected }) => { | ||
| expect( | ||
| isAllowedConventionTransition(convention, targetStatus, roles), | ||
| ).toBe(expected); | ||
| }, | ||
| ); | ||
| }); |