Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Personio API changes #193

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Adapt to Personio API changes #193

merged 1 commit into from
Sep 17, 2024

Conversation

lyind
Copy link
Contributor

@lyind lyind commented Sep 16, 2024

Summary

Personio removed several fields from their TimeOffType response object:

    legacy_category
    half_day_requests_enabled
    certification_required
    certification_submission_timeframe
    substitute_option

This PR removes all use of these fields in the library.

@lyind lyind self-assigned this Sep 16, 2024
@lyind lyind requested a review from a team as a code owner September 16, 2024 16:08
Copy link

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but does it mean that half days still exist?

@lyind
Copy link
Contributor Author

lyind commented Sep 17, 2024

but does it mean that half days still exist?

Yes. In fact, this means everything is now tracked in half-days instead of days. This is a first step (Personio did that internally to work towards improvements).

The switch to hourly tracking is separate from this.

@lyind lyind merged commit 90cd8fc into main Sep 17, 2024
6 checks passed
@lyind lyind deleted the changes-sep-16 branch September 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants