error #3
Open
error #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
This change moves the lock so that it protects a call to __skb_dequeue(). Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
The incorrect placement of a lock meant that the TX ring queue was not protected. On one system, this led to freezes when running rtl8192ee. When checking the other drivers to see which ones are affected, it was discovered that several of them used identical code. Accordingly, this routine was moved into core.c where all the drivers could share a single copy. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Conflicts: rtl8188ee/fw.c rtl8192c/fw_common.c rtl8192de/fw.c rtl8192ee/fw.c rtl8723ae/fw.c rtl8723be/fw.c rtl8821ae/fw.c
Conflicts: rtl8188ee/trx.c
In a number of places, kmalloc or valloc were used to acquire memory. To ensure that these locations are correctly initialized, the calls were changed to kzalloc and vzalloc. The change seems to have cleared a problem that was causing HT operations to be cancelled. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Conflicts: rtl8723ae/hal_btc.c
In kernel 3.13.0-XX where XX is >= 32, Ubuntu has implemented the API
change that was introduced in mainline V3.15 by commit d8ca16db6bb2 ("mac80211:
add length check in ieee80211_is_robust_mgmt_frame()"). The result is that the
code in this repo gets it wrong for Ubuntu kernels. The result is
a kernel that crashes when using the corresponging driver. Thanks to user
"lenonk" at GitHub, there is a fix. I have not tested it as I do not use one
of the affected kernels; however, it looks correct.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Whe uninstalling the drivers, the saved versions are restored. Firmware is not touched when uninstalling. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
…as never mapped This fix is a kluge. I'm not sure that these buffers are mapped under any circumstance. At least the splat goes away. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Conflicts: rtl8192ee/hw.c
---------------------- 11A Throughput is very low because ratr is not initialized
--------------------- this will affect some modes that issue beacon
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
…ation The low-level routines involve the use of outb(), etc. These routines are not available for all architectures, and some builds will fail. The high-level routines are correct for all architectures. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Driver rtlwifi has been modified to call ieee80211_register_hw() from the probe routine; however, the existing call in the callback routine for deferred firmware loading was not removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
In 3.18, the kernel contains options to compress the modules. When this option is selected, installation of modules from this repo resulted in a mixture of old and new versions that would not load correctly. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Device RTL8812AE fails to work on these kernels if VHT is enabled because of lack of implementation for add_chanctx. Signed-off-by: troy-tan <troy_tan@realsil.com.cn>
---------------------- make cam code more easy to view and prepare for concurrent function
------------------------------- 1.fix cannot parse C2H CMD 2.fix TX HANG when adhoc is setup 3.fix TX HANG sometimes 4.fix rx desc unavailable Author: troy-tan <troy_tan@realsil.com.cn> Date: Mon Jan 12 10:17:32 2015 +0800
This callback routine pointer was added to driver rtl8192ee to help fix the stability of the connection. One problem with that fix is that this pointer is undefined for the rest of the drivers. To prevent crashes, we need to test for a non-NULL pointer before we call the routine. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Installation instruction added.
Update README.md
Update README.md Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
There has been a coding error in rtl8821ae since it was first introduced,
namely that an 8-bit register was read using a 16-bit read in
_rtl8821ae_dbi_read(). This error was fixed with commit 40b368af4b75
("rtlwifi: Fix alignment issues"); however, this change led to
instability in the connection. To restore stability, this change
was reverted in commit b8b8b16352cd ("rtlwifi: rtl8821ae: Fix connection
lost problem").
Unfortunately, the unaligned access caueses machine checks in ARM
architecture, and we were forced to evaluate the actual cause of the
problem on x86 platforms. Following a suggestion from Pkshih
<pkshih@realtek.com>, it was found that by increasing the ASPM L1
latency from 0 to 7 fixed the stability. This parameter was varied to
see if a smaller value would work; however, it appears that 7 is the
safest value. A new symbol is defined for this quantity, thus it can be
easily changed if necessary.
Fixes: b8b8b16352cd ("rtlwifi: rtl8821ae: Fix connection lost problem")
Cc: Stable <stable@vger.kernel.org> # 4.14+
Fix-suggested-by: Pkshih <pkshih@realtek.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Obviously, a number of people continue to want to use this master branch. Rather than fix the problems in submitted patches, or try to figure out what is happening in others, I decided to spend the time fixing the code myself. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
When connecting to AP, mac80211 asks driver to enter and leave PS quickly, but driver deinit doesn't wait for delayed work complete when entering PS, then driver reinit procedure and delay work are running simultaneously. This will cause unpredictable kernel oops or crash like rtl8723be: error H2C cmd because of Fw download fail!!! WARNING: CPU: 3 PID: 159 at drivers/net/wireless/realtek/rtlwifi/ rtl8723be/fw.c:227 rtl8723be_fill_h2c_cmd+0x182/0x510 [rtl8723be] CPU: 3 PID: 159 Comm: kworker/3:2 Tainted: G O 4.16.13-2-ARCH ghotiv#1 Hardware name: ASUSTeK COMPUTER INC. X556UF/X556UF, BIOS X556UF.406 10/21/2016 Workqueue: rtl8723be_pci rtl_c2hcmd_wq_callback [rtlwifi] RIP: 0010:rtl8723be_fill_h2c_cmd+0x182/0x510 [rtl8723be] RSP: 0018:ffffa6ab01e1bd70 EFLAGS: 00010282 RAX: 0000000000000000 RBX: ffffa26069071520 RCX: 0000000000000001 RDX: 0000000080000001 RSI: ffffffff8be70e9c RDI: 00000000ffffffff RBP: 0000000000000000 R08: 0000000000000048 R09: 0000000000000348 R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000000 R13: ffffa26069071520 R14: 0000000000000000 R15: ffffa2607d205f70 FS: 0000000000000000(0000) GS:ffffa26081d80000(0000) knlGS:000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000443b39d3000 CR3: 000000037700a005 CR4: 00000000003606e0 Call Trace: ? halbtc_send_bt_mp_operation.constprop.17+0xd5/0xe0 [btcoexist] ? ex_btc8723b1ant_bt_info_notify+0x3b8/0x820 [btcoexist] ? rtl_c2hcmd_launcher+0xab/0x110 [rtlwifi] ? process_one_work+0x1d1/0x3b0 ? worker_thread+0x2b/0x3d0 ? process_one_work+0x3b0/0x3b0 ? kthread+0x112/0x130 ? kthread_create_on_node+0x60/0x60 ? ret_from_fork+0x35/0x40 Code: 00 76 b4 e9 e2 fe ff ff 4c 89 ee 4c 89 e7 e8 56 22 86 ca e9 5e ... This patch ensures all delayed works done before entering PS to satisfy our expectation, so use cancel_delayed_work_sync() instead. An exception is delayed work ips_nic_off_wq because running task may be itself, so add a parameter ips_wq to deinit function to handle this case. This issue is reported and fixed in below threads: https://github.com/lwfinger/rtlwifi_new/issues/367 https://github.com/lwfinger/rtlwifi_new/issues/366 Tested-by: Evgeny Kapun <abacabadabacaba@gmail.com> # 8723DE Tested-by: Shivam Kakkar <shivam543@gmail.com> # 8723BE on 4.18-rc1 Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Fixes: cceb0a597320 ("rtlwifi: Add work queue for c2h cmd.") Cc: Stable <stable@vger.kernel.org> # 4.11+ Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Remove the .cache.mk in master branch Thanks.
This bug results in "firmware not ready to run" errors. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
master sync
adding wireless grap command.
adding wireless grap command.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
fix warning for compile
On four of the drivers, the wakeup test is performed twice on bit 31, rather than once each on bits 29 and 31. Thanks to Valerii Zapodovnikov for alerting me to this error. Note that the only effect is to output the wrong value in an debug error message. It has no affect on normal operation. This patch also fixes the time-of-day errors in the master branch. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
The variable is never used outside the <driver>_rx_query_desc() routine, and then only for local debugging. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
owitor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error