fix npx convex run --watch --component-path and make schemas reacti…

…ve (#29494)

fix the CLI so it passes through component path when you do `npx convex run --watch`.

and on schema failures we can rebuild when the data changes in the component whose schema failed.

also there was a bug: when the websocket starts up after creating a query, which happens occasionally in the dashboard and happens every time when the CLI calls `subscribe`, we weren't passing the component path the second time.

GitOrigin-RevId: ee29a46f68ca5726051686636faf1ddb434036c0

src/browser/sync/local_state.ts

@@ -24,6 +24,7 @@ type LocalQuery = {
   args: Record<string, Value>;
   numSubscribers: number;
   journal?: QueryJournal;
+  componentPath?: string;
 };
 
 export class LocalSyncState {
@@ -95,6 +96,7 @@ export class LocalSyncState {
         args,
         numSubscribers: 1,
         journal,
+        componentPath,
       };
       this.querySet.set(queryToken, query);
       this.queryIdToToken.set(queryId, queryToken);
@@ -279,6 +281,7 @@ export class LocalSyncState {
         udfPath: localQuery.canonicalizedUdfPath,
         args: [convexToJson(localQuery.args)],
         journal: localQuery.journal,
+        componentPath: localQuery.componentPath,
       };
       modifications.push(add);
 

src/bundler/context.ts

@@ -16,7 +16,10 @@ export type ErrorType =
   // The `convex dev` command will wait for either file OR table data change
   // to retry (if a table name is specified as the value in this Object).
   | {
-      "invalid filesystem or db data": string | null;
+      "invalid filesystem or db data": {
+        tableName: string;
+        componentPath?: string;
+      } | null;
     }
   // The error was caused by either the local state (ie schema.ts content)
   // or the state of the deployment environment variables.

src/cli/convexExport.ts

@@ -145,6 +145,7 @@ async function waitForStableExportState(
     adminKey,
     "_system/cli/exports:getLatest",
     {},
+    undefined,
     donePromise,
     {
       onChange: (value: any) => {

src/cli/convexImport.ts

@@ -363,6 +363,7 @@ export async function waitForStableImportState(
     adminKey,
     "_system/cli/queryImport",
     { importId },
+    undefined,
     donePromise,
     {
       onChange: (value: any) => {

src/cli/dev.ts

@@ -306,7 +306,12 @@ export async function watchAndPush(
       return;
     }
     const fileSystemWatch = getFileSystemWatch(ctx, watch, cmdOptions);
-    const tableWatch = getTableWatch(ctx, options, tableNameTriggeringRetry);
+    const tableWatch = getTableWatch(
+      ctx,
+      options,
+      tableNameTriggeringRetry?.tableName ?? null,
+      tableNameTriggeringRetry?.componentPath,
+    );
     const envVarWatch = getDeplymentEnvVarWatch(
       ctx,
       options,
@@ -330,9 +335,14 @@ function getTableWatch(
     adminKey: string;
   },
   tableName: string | null,
+  componentPath: string | undefined,
 ) {
-  return getFunctionWatch(ctx, credentials, "_system/cli/queryTable", () =>
-    tableName !== null ? { tableName } : null,
+  return getFunctionWatch(
+    ctx,
+    credentials,
+    "_system/cli/queryTable",
+    () => (tableName !== null ? { tableName } : null),
+    componentPath,
   );
 }
 
@@ -349,6 +359,7 @@ function getDeplymentEnvVarWatch(
     credentials,
     "_system/cli/queryEnvironmentVariables",
     () => (shouldRetryOnDeploymentEnvVarChange ? {} : null),
+    undefined,
   );
 }
 
@@ -360,6 +371,7 @@ function getFunctionWatch(
   },
   functionName: string,
   getArgs: () => Record<string, Value> | null,
+  componentPath: string | undefined,
 ) {
   const [stopPromise, stop] = waitUntilCalled();
   return {
@@ -375,6 +387,7 @@ function getFunctionWatch(
         credentials.adminKey,
         functionName,
         args,
+        componentPath,
         stopPromise,
         {
           onChange: () => {

src/cli/lib/deploy2.ts

@@ -154,7 +154,12 @@ export async function waitForSchema(
         return await ctx.crash({
           exitCode: 1,
           errorType: {
-            "invalid filesystem or db data": currentStatus.tableName ?? null,
+            "invalid filesystem or db data": currentStatus.tableName
+              ? {
+                  tableName: currentStatus.tableName,
+                  componentPath: currentStatus.componentPath,
+                }
+              : null,
           },
           printedMessage: null, // TODO - move logging into here
         });

src/cli/lib/indexes.ts

@@ -133,7 +133,11 @@ async function waitForReadySchema(
       return await ctx.crash({
         exitCode: 1,
         errorType: {
-          "invalid filesystem or db data": data.schemaState.tableName ?? null,
+          "invalid filesystem or db data": data.schemaState.tableName
+            ? {
+                tableName: data.schemaState.tableName,
+              }
+            : null,
         },
         printedMessage: null, // TODO - move logging into here
       });

src/cli/lib/run.ts

@@ -125,13 +125,15 @@ export async function subscribeAndLog(
   adminKey: string,
   functionName: string,
   args: Record<string, Value>,
+  componentPath: string | undefined,
 ) {
   return subscribe(
     ctx,
     deploymentUrl,
     adminKey,
     functionName,
     args,
+    componentPath,
     waitForever(),
     {
       onStart() {
@@ -156,6 +158,7 @@ export async function subscribe(
   adminKey: string,
   functionName: string,
   args: Record<string, Value>,
+  componentPath: string | undefined,
   until: Promise<unknown>,
   callbacks?: {
     onStart?: () => void;
@@ -177,7 +180,9 @@ export async function subscribe(
     },
   );
   client.setAdminAuth(adminKey);
-  const { unsubscribe } = client.subscribe(functionName, args);
+  const { unsubscribe } = client.subscribe(functionName, args, {
+    componentPath,
+  });
 
   callbacks?.onStart?.();
 

src/cli/run.ts

@@ -103,6 +103,7 @@ export const run = new Command("run")
         adminKey,
         functionName,
         args,
+        options.componentPath,
       );
     }
     return await runFunctionAndLog(