Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10505 Allow to specify use of proxy or cors at layer level #10526

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rowheat02
Copy link
Contributor

@rowheat02 rowheat02 commented Sep 2, 2024

Description

  • fixes Allow to specify use of proxy or cors at layer level #10505. proxy by default implemented if any endpoint fails due to CORS
  • UI removed for: Force proxy (Layer Settings) and the Allow not secure layers
  • Interceptor has been used to use retry with proxy to all Axios endpoints.
  • For Cesium, before adding a layer to the map one preflight request is used to check CORS and use the proxy.
  • Common proxy cache for both cases.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10505

What is the new behavior?
AutoProxy for CORS disabled endpoints.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 changed the title Enhancement/autoproxyforlayers fix #10505 Allow to specify use of proxy or cors at layer level Sep 2, 2024
@rowheat02 rowheat02 self-assigned this Sep 2, 2024
@rowheat02 rowheat02 added this to the 2024.02.00 milestone Sep 2, 2024
@tdipisa tdipisa linked an issue Sep 2, 2024 that may be closed by this pull request
6 tasks
@tdipisa tdipisa modified the milestones: 2024.02.00, 2025.01.00 Sep 6, 2024
@rowheat02
Copy link
Contributor Author

  • UI removed for: Force proxy (Layer Settings) and the Allow not secure layers
  • If any api fails due to CORS, proxy will be used by default in ajax interceptor.
  • In case of cesium, preflight CORS check api will be called before adding layer and forceProxy option will be used to create new layer which handle proxy logic in layers.
  • common proxy cache logic implemented.
  • Old Failed test cases other than "should create a bil terrain provider with wms config" have been solved. In this last failed test, two async parts are there throwing timeout error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify use of proxy or cors at layer level
2 participants