Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10521 - Update center comparison in OL map component #10525

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Aug 30, 2024

Description

This PR updates OL map component's map position update in comparing center. Instead of performing an exact match comparison, a nearly equal match is performed with precision of 0.00000001

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?
The map update is skipped when center is nearly equal avoiding unnecessary map update

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@ElenaGallo
We cannot test it effectively in MS, but we can test for regression to ensure the change hasn't impacted any map functionality

@MV88
Copy link
Contributor

MV88 commented Aug 30, 2024

@tdipisa @dsuren1
merging this because the test issue is not related to this, also because this is crucial to the project update we know

@dsuren1 dsuren1 enabled auto-merge (squash) August 30, 2024 11:15
@dsuren1 dsuren1 disabled auto-merge August 30, 2024 11:22
@MV88 MV88 merged commit 842b59b into geosolutions-it:master Aug 30, 2024
4 of 5 checks passed
@tdipisa tdipisa linked an issue Sep 2, 2024 that may be closed by this pull request
1 task
@MV88
Copy link
Contributor

MV88 commented Sep 2, 2024

@ElenaGallo I will test this locally as soon this gets included in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance OL map component in updating map position based on center
2 participants