Simplify Wkt data structure #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/rm-wkt-item
branch
from
efaf61c
to
e08daf4
Compare
3 tasks
michaelkirk
force-pushed
the
mkirk/rm-wkt-item
branch
from
e08daf4
to
d0201d9
Compare
michaelkirk
commented
Sep 16, 2023
| @@ -142,7 +141,7 @@ impl<T> WktFloat for T where T: WktNum + Float {} | |||
|
|
|||
| #[derive(Clone, Debug, PartialEq)] | |||
| /// All supported WKT geometry [`types`] | |||
| pub enum Geometry<T> | |||
There was a problem hiding this comment.
The crux of the change is this and deleting the old Wkt struct
frewsxcv
approved these changes
Sep 16, 2023
This is a large breaking change to simplify the Wkt data structure. Wkt had a single field - `item` of type `Geometry`. So everything about a Wkt was determined by its item. In effect, Wkt was serving no purpose. So I replaced Wkt with it's inner Geometry.
michaelkirk
force-pushed
the
mkirk/rm-wkt-item
branch
from
d0201d9
to
87e501d
Compare
|
This sat here a long time and I forgot about it. I've rebased! Can I get another review? |
|
Well, I got an approval a long time ago and it really seems like no one cares much, so I'm going to merge this before it goes stale again. |
|
Ah the luck of you merging this right when I was working on ZM support 🥲 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This is based on #109, so review that first.Merged!It's a large breaking change, so I'd appreciate getting at least a couple opinions.