Adding Attenuation Model of Ghasemi (2009) #9644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoided instantiating gsim_lt too much
Splitting aristotle.main into `main_cmd` and `main_web`
[WIP] Aki and Richards test fix
Replacing round with numpy.round
Clarification of USGS CEUS 2018 GMPE docstring
…n and to display it in the job description
Adding the ability to start an Aristotle computation from a rupture_model.xml
Extended `forbid_long_funcs` to commonlib
More refactoring for PostLossAmplification
Removed the XML exporters deprecated years ago
Fixed post loss amplification for aggrisk
micheles
reviewed
May 9, 2024
Renamed event_risk_test -> gmf_ebrisk_test
The word "Excel" is corrected (L#24)
mmpagani
approved these changes
May 9, 2024
There was a problem hiding this comment.
Thank you. Overall this PR looks good to me. Please add your name here https://github.com/gem/oq-engine/blob/master/CONTRIBUTORS.txt and update this file https://github.com/gem/oq-engine/blob/master/debian/changelog
Mmax relative uncertainty without moment balancing
[WIP] changing comparison point of tolerance for the kite fault meshes
|
Tests are red; please make sure to refresh your branch with a |
|
a problem has occurred during updating. So I closed this pull request and I will open another one with all required changes discussed here. Thank you for your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attenuation model of Ghasemi (2009) is developed for Iran with the doi of 10.1007/s10950-008-9143-x.
A gsim library of this model is added.
The version and tag of openquake engine used to develope this library is 3.17.1.
The changes made are:
1- A gsim library of "ghasemi_2009.py" is added to openquake\hazardlib\gsim.
2- A test file of "ghasemi_2009_test.py" is added to openquake\hazardlib\tests\gsim
3- A verification table of "Ghasemi09.xlsx" is added to openquake\hazardlib\tests\gsim\data.
The verification is done using an excel file which calculates the Sa(T1) based on model developed by Ghasemi2009. The
results obtained from this excel file is compared with the ones obtained from oq.
4- The "openquake.hazardlib.gsim.rst" file is modified so that it includes "ghasemi_2009" gsim library.