Exporting AOP, EOP curves #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the desired items among ep, aep and oep
ptormene
reviewed
Sep 19, 2023
| dic['oep'] = losses_by_period(oep, periods, ne, self.eff_time) | ||
| dic = {kind: losses_by_period(losses, periods, ne, self.eff_time)} | ||
| # NOTE: assuming 'ep' mandatory and 'oep' and 'aep' optional | ||
| if len(years) and kind == 'loss': |
There was a problem hiding this comment.
Perhaps it would be better to change this into
if len(years) > 1 and kind == 'loss'
in order to avoid computing loss_oep and loss_aep when they are equal to loss
There was a problem hiding this comment.
No, it would be confusing to the user because by changing the effective time sometime she would get some curves and sometimes not.
There was a problem hiding this comment.
Ok, so by default all curves will be computed, unless otherwise specified in the ini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8971