Support MySQL 8.4 #549
Open
Support MySQL 8.4 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerlingguy
reviewed
Aug 19, 2024
| @@ -61,7 +73,7 @@ | |||
| with_items: "{{ mysql_root_hosts.stdout_lines|default([]) }}" | |||
| when: > | |||
| ((mysql_install_packages | bool) or mysql_root_password_update) | |||
| and ('5.7.' not in mysql_cli_version.stdout and '8.0.' not in mysql_cli_version.stdout) | |||
| and ('5.7.' not in mysql_cli_version.stdout and '8.' not in mysql_cli_version.stdout) | |||
There was a problem hiding this comment.
The only downside to this change is maybe the comparison would break if there were a version like 5.8.0, that version would be identified as 8.... trying to think of a better way to narrow it. Maybe add in something to trim off the first two digits, and compare that to 8.?
There was a problem hiding this comment.
I was thinking about this solution, but as far as I know, version 5.8 doesn't exist. However, everything works fine on version >= 5.7. If you want, I can change the version definition using trim.
There was a problem hiding this comment.
I think using trim would be ever so slightly more future proof. It feels more correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the method for resetting the root user password in MySQL 8+ since
mysql_native_passwordis no longer enabled by default. Link https://dev.mysql.com/doc/refman/8.4/en/native-pluggable-authentication.htmlNow, versions of MySQL 8.* are correctly identified.