This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
[Fix] : 간헐적 test fail 해결 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldentrash
commented
Oct 21, 2023
| } | ||
| } else { | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| for (const data of mockData) { |
There was a problem hiding this comment.
기존 mockData.forEach에서 for...of 로의 변경이 주 사항입니다
l2hyunwoo
reviewed
Oct 22, 2023
Comment on lines
+139
to
+141
|
|
||
| // eslint-disable-next-line import/prefer-default-export | ||
| export { init }; |
There was a problem hiding this comment.
이것도 그냥 export default 로 바쒀도 되었을듯?
There was a problem hiding this comment.
다른 파일까지 바꿀 엄두가 안 나서.... 지금 lint fail이 너무 많아서 건들기 무서워요
방금 혹시나해서 건드려봤는데 역시 줄줄이 터져서 나중에 하는거로 :)
l2hyunwoo
reviewed
Oct 22, 2023
Comment on lines
+13
to
+14
|
|
||
| const mockData = require('../data/mockData.json'); |
There was a problem hiding this comment.
이 친구는 commonjs 방식 쓴 이유가 있나요? 라고 하기엔 기존 코드 승계구나
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test DB init 중, 모든 data가 load 완료 될 때 까지 기다리지 않아 간헐적으로 test가 fail하던 문제를 해결했습니다.
mock data를 동기적으로 load하다보니,
BurritoStore가 score가 0 미만인 경우dec정보를 무시해 다른 test가 연쇄적으로 fail하는 문제가 발생했습니다. 우선 mock data 순서를 변경해 모든 data가 load 가능하도록 임시 조치해뒀습니다.최대한 현 lint 룰에 맞춰 수정하려 했지만, dependency version up이 필요한 경우과 같은 몇몇 경우는 disable 했습니다.