-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰확인좀
src/config/index.ts
Outdated
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':burrito:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottenburrito:'), | ||
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':goose:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottengoose:'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rottenGoose 없애고 여기는 아예 undefined로 정의합시다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 undefined로 정의한다고 하면 env값에는 아무것도 설정하지 않고, ‘rottengoose’를 undefined로 바꾼다는 말씀이신가요???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env값에는 아무것도 설정하지 않고
yes
‘rottengoose’를 undefined로 바꾼다는 말씀이신가요???
이런식으로
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottengoose:'), | |
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC), |
src/config/index.ts
Outdated
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':burrito:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottenburrito:'), | ||
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':goose:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottengoose:'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도
src/config/index.ts
Outdated
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':burrito:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottenburrito:'), | ||
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':goose:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottengoose:'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도
src/config/index.ts
Outdated
api_token: mustHave('SLACK_API_TOKEN'), | ||
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':burrito:'), | ||
emojiDec: fixEmoji(process.env.SLACK_EMOJI_DEC || ':rottenburrito:'), | ||
emojiInc: fixEmoji(process.env.SLACK_EMOJI_INC || ':goose:'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
할로윈이니까 🍬 (: candy :) 추가하는 것도 괜찮을듯(기간제)
+) 🪿 없을거야, 🦆(: duck :)으로 갑시다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우선 duck으로 적용시키겠습니다. 이모지자체만 (: duck :)으로 바꾸고 변수명등 나머지는 그대로 goose로 유지하나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좀 옆길로 새본다면 슬랙 커스텀 이모지로 :goose:
만들수 있긴합니다. 이미지만 있다면•••
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hughesgoon 하긴 그렇긴 함ㅋㅋㅋ 그러면 🪿 일단 추가하고 건구스 사진 추가하고 🪿이모지 만드는 방향으로 가죠! @ekgns33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l2hyunwoo 앗 duck으로 적용하고 코멘트가 생겼네요 ㅜㅜ default를 duck으로 두고 env에서 goose를 적용시키는 방법은 별로일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekgns33 그 방향으로 가시죠!
Test 깨졌는데 한번 확인해주시겠어요? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gogo!
프로젝트 코드내에 Burrito를 Goose로 변경
작업내역
특이사항