Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin compatibility with JupyterLab 3.0 and release 0.4.0 version #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dominos
Copy link

@Dominos Dominos commented Jan 11, 2022

We've upgraded the extension following by https://jupyterlab.readthedocs.io/en/stable/extension/extension_migration.html

It's been tested and works as expected

@Dominos
Copy link
Author

Dominos commented Jan 11, 2022

Hey @mikehcheng, may I ask you to review the PR?

@kbroughton
Copy link

would be great if you could merge this and push a new pip version

@Dominos
Copy link
Author

Dominos commented Feb 18, 2022

@kbroughton actually we've built our internal CI/CD pipeline and publish in our internal artifactory.

If you want here's a sample to build this package on Github Actions:

name: CI

on: [push, workflow_dispatch]

jobs:
  Build:
    runs-on: [ self-hosted, ubuntu ]
    steps:
      - name: Checkout source code
        uses: actions/checkout@v2

      - name: setup npm & nodejs
        uses: actions/setup-node@v2
        with:
          node-version: '16'

      - name: setup Python3.8 environment
        uses: actions/setup-python@v2
        with:
          python-version: '3.8'

      - name: install build dependencies
        run: python3.8 -m pip install -r build_requirements.txt

      - name: build package
        run: python3.8 -m build

@mimizone
Copy link

checking if somebody is still considering merging this and making it available to the labextension repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants