Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-361: Improve Gaffer Gremlin examples #362

Merged
merged 4 commits into from
May 29, 2024
Merged

Gh-361: Improve Gaffer Gremlin examples #362

merged 4 commits into from
May 29, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented May 20, 2024 •
edited
Loading

Updated the existing notebook and added a new one that uses the graph-notebook extension for visualisation. Took liberty to do some minor tidying to files too.

Related issue

@GCHQDeveloper314 GCHQDeveloper314 changed the title Gh-361 Improve gaffer gremlin examples Gh-361: Improve Gaffer Gremlin examples May 20, 2024
GCHQDeveloper314
GCHQDeveloper314 requested changes May 21, 2024
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new graphnotebook doesn't work. This might be a git check in problem as I have some strange errors.

docker/gaffer-gremlin/README.md Outdated Show resolved Hide resolved
docker/gaffer-gremlin/example/notebooks/graphnotebook-modern-example.ipynb Show resolved Hide resolved
docker/gaffer-gremlin/example/compose.yaml Outdated Show resolved Hide resolved
docker/gaffer-gremlin/example/notebooks/graphnotebook-modern-example.ipynb Outdated Show resolved Hide resolved
docker/gaffer-gremlin/example/notebooks/gremlinpython-modern-example.ipynb Outdated Show resolved Hide resolved
tb06904 and others added 2 commits May 23, 2024 11:32
@tb06904
move to a unified start script and readonly example
acbae4e
@tb06904 @cn337131
Apply suggestions from code review
3b263e5 
Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>
GCHQDeveloper314
GCHQDeveloper314 approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the notebook in Jupyter locally and it is now working for me as expected.

@GCHQDeveloper314 GCHQDeveloper314 merged commit b7ab17a into develop May 29, 2024
2 checks passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-361-improve-gaffer-gremlin-examples branch May 29, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

@cn337131 cn337131 cn337131 approved these changes

@l46978 l46978 Awaiting requested review from l46978

@p29876 p29876 Awaiting requested review from p29876

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the gaffer-gremlin example
3 participants
@tb06904 @GCHQDeveloper314 @cn337131