-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
137 use iris in hqdm rdf entity factories #156
137 use iris in hqdm rdf entity factories #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I can't approve this since it's my PR - looks good though so feel free to merge when you're ready 👍
hqdm/src/test/java/uk/gov/gchq/magmacore/hqdm/pojo/HqdmObjectTest.java
Outdated
Show resolved
Hide resolved
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well worth doing this as it results in far cleaner code and, importantly, the interfacing to services. Looks good to me!
Comment copied from the corresponding issue:
So, if I changed only the
Rdf*Services
classes then that's only half the job - the classes in thehqdm
module would still need conversion to and from IRIs in the rest of the code, so I decided to change them as well to reduce clutter further. In summary:hqdm-rdf
module has been subsumed into thehqdm
module. (I could have gone the other direction, but this seemed to be the right way to go).RDF*Services
is now replaced by the*Services
in thehqdm
module.IRI
objects to and fromString
objects when using the classes, and no need to create temporaryIRI
objects any more.I have tested the impact on client code and it is a breaking change, but it makes the MagmaCore library easier to use. The two projects I tried it on both have quite a few changes to make but the resulting code is less cluttered and less clunky.