lightbox mobile #2460
Merged
lightbox mobile #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 6f344c5 Route: No significant changes found Dynamic import: No significant changes found |
Robinnnnn
reviewed
May 10, 2024
Comment on lines
205
to
207
| const handleMaximizeToggle = () => { | ||
| setIsLightboxOpen((currIsLightboxOpen) => !currIsLightboxOpen); | ||
| }; |
There was a problem hiding this comment.
let's make sure to wrap in useCallback
Comment on lines
217
to
237
| const updateThumbnailPosition = () => { | ||
| if (thumbnailRef.current) { | ||
| thumbnailRef.current.measure((x, y, w, h, pageX, pageY) => { | ||
| setThumbnailPosition({ | ||
| width: w, | ||
| height: h, | ||
| x: pageX, | ||
| y: pageY, | ||
| }); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| const handleOpenLightbox = () => { | ||
| updateThumbnailPosition(); | ||
| setIsLightboxOpen(true); | ||
| }; | ||
|
|
||
| const handleCloseLightbox = () => { | ||
| setIsLightboxOpen(false); | ||
| }; |
Comment on lines
267
to
288
| renderContent={() => ( | ||
| <TokenFailureBoundary tokenRef={token} variant="large"> | ||
| <NftDetailAssetCacheSwapper | ||
| cachedPreviewAssetUrl={route.params.cachedPreviewAssetUrl} | ||
| > | ||
| <Zoom | ||
| contentContainerStyle={{ | ||
| display: 'flex', | ||
| width: width, | ||
| flexGrow: 1, | ||
| backgroundColor: colors.black['800'], | ||
| }} | ||
| style={{ display: 'flex', flexGrow: 1 }} | ||
| doubleTapConfig={{ | ||
| minZoomScale: 1, | ||
| }} | ||
| > | ||
| <NftDetailAsset tokenRef={token} /> | ||
| </Zoom> | ||
| </NftDetailAssetCacheSwapper> | ||
| </TokenFailureBoundary> | ||
| )} |
There was a problem hiding this comment.
let's define this as a useCallback
Comment on lines
289
to
294
| origin={{ | ||
| x: thumbnailPosition.x, | ||
| y: thumbnailPosition.y, | ||
| width: thumbnailPosition.width, | ||
| height: thumbnailPosition.height, | ||
| }} |
There was a problem hiding this comment.
useMemo where the dependency is [thumbnailPosition]
| > | ||
| <View | ||
| ref={thumbnailRef} | ||
| style={{ width: width * 0.92, minHeight: width * 0.92 }} |
Robinnnnn
approved these changes
May 15, 2024
Robinnnnn
added a commit
that referenced
this pull request
May 16, 2024
This reverts commit 7569238.
Robinnnnn
added a commit
that referenced
this pull request
May 16, 2024
Rohan-cp
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Screen.Recording.2024-05-10.at.13.47.19.mov
Edge Cases
List any common edge cases that you have considered and tested.
Testing Steps
Provide steps on how the reviewer can test the changes.
Checklist
Please make sure to review and check all of the following: