Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mchx campaign banner and mint on gallery #2423

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Conversation

pvicensSpacedev
Copy link
Collaborator

Summary of Changes

  • Added the banner for mchx mint in mobile (web still in progress)
  • Added pin notification UI (have to properly get the data from the backend)
  • Added Mint on gallery button (opens campaign bottom sheet) if not claimed and mint on highlight if already minted

Demo or Before/After Pics

Screenshot 2024-04-11 at 17 13 22
Screenshot 2024-04-11 at 17 13 30
Screenshot 2024-04-11 at 17 13 26
Screenshot 2024-04-11 at 17 13 50
Screenshot 2024-04-11 at 15 44 07
Screenshot 2024-04-11 at 17 13 38

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 7:07pm

Copy link

github-actions bot commented Apr 11, 2024

Bundle Sizes

Compared against fa90cde

Route: No significant changes found

Dynamic import: No significant changes found

@kaitoo1
Copy link
Collaborator

kaitoo1 commented Apr 12, 2024

we should show the Gallery G logo here instead of Foundation's
CleanShot 2024-04-12 at 11 25 04

@kaitoo1
Copy link
Collaborator

kaitoo1 commented Apr 12, 2024

and if it's "Mint on Gallery" I think we can toss the diagonal arrow since that is saying it's an external site

@kaitoo1
Copy link
Collaborator

kaitoo1 commented Apr 12, 2024

otherwise looks great! banner looks nice too 🔥

@Robinnnnn Robinnnnn merged commit c9af88b into main Apr 12, 2024
8 of 9 checks passed
@Robinnnnn Robinnnnn deleted the pato/mchx-campaign-changes branch April 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants