Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: wallet truncation on nft detail mobile #2419

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Apr 9, 2024

Summary of Changes

Provide a brief description of the changes made in this PR. Explain the problem you are fixing or the feature you are adding.

Demo or Before/After Pics

Before After
Screenshot 2024-04-09 at 19 46 40 Screenshot 2024-04-09 at 19 45 17

Edge Cases

when address is name still working as per usual

Screenshot 2024-04-09 at 19 48 39

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@Rohan-cp Rohan-cp requested a review from Robinnnnn April 9, 2024 23:47
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 11:52pm

@github-actions github-actions bot added the mobile label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Bundle Sizes

Compared against 45bee60

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit 2d4ebd9 into main Apr 10, 2024
9 checks passed
@Robinnnnn Robinnnnn deleted the rohan/small-truncation-wallet-fix branch April 10, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants