hide deleted comment if no replies #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against 272545c Route: No significant changes found Dynamic import: No significant changes found |
Robinnnnn
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
If the comment that has been deleted has no replies then hide that comment.
Made the changes for both web and mobile
Demo or Before/After Pics
More pics:
Edge Cases
I'd just like to note the fact that if the post has 1 comment (that is deleted) then the condition to show "No comments yet" is not fulfilled and thus just shows a blank screen as in the screenshot.
I tried fixing this but am unsure how to get the comments replies in the parent component's query. It currently just checks if there are comments without ever checking if its deleted or not
Checklist
Please make sure to review and check all of the following: