Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Add all networks dropdown (web) #2354

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

pvicensSpacedev
Copy link
Collaborator

@pvicensSpacedev pvicensSpacedev commented Mar 8, 2024

⚠️ NOTE: blocked on merging pending perf improvements

Summary of Changes

Added all networks option in web. Changed types to accomodate 'All Networks' which means we should modify it in mobile as well.
There is a refresh bug currently in mobile that sort of blocks it though.

Demo or Before/After Pics

Screenshot 2024-03-08 at 17 27 58
Screenshot 2024-03-08 at 17 27 29

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:40pm

Copy link

github-actions bot commented Mar 8, 2024

Bundle Sizes

Compared against 5ae8213

Route: No significant changes found

Dynamic import: No significant changes found

Copy link
Contributor

@Robinnnnn Robinnnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

can we enable the refresh button when All Networks are selected, and pass in all networks to refresh in an array?

@pvicensSpacedev
Copy link
Collaborator Author

image

can we enable the refresh button when All Networks are selected, and pass in all networks to refresh in an array?

When are you seeing this disabled? I'm seeing it enabled all the time

Screenshot 2024-03-13 at 13 48 20

@Robinnnnn Robinnnnn changed the title Add all networks dropdown (web) [do not merge] Add all networks dropdown (web) Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants