chore: use NotoSerifCJK-Regular.ttc instead of NotoSerifCJKkr-Regular.otf #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why would i want that? i got one test for this, one test for this. im good with that. |
|
how about we create one PR for just the xmake changes, and the try to see how we got about exporting without testing in another? i'll take care of this sometime today (and with the other thing as well - creating packages without testing) |
galkahana
added a commit
that referenced
this pull request
Dec 27, 2023
galkahana
added a commit
that referenced
this pull request
Dec 27, 2023
|
@darcy-shen i incorporated the changes to the xmake config you added here in: please let me know if i correctly represented your intent. |
galkahana
added a commit
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NotoSerifCJKkr-Regular.otfis a subset ofNotoSerifCJK-Regular.ttc, use ttc and remove otf to reduce the size of the git repo.