-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Foreign Amount #639
Fix: Foreign Amount #639
Conversation
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/netsuite/connector.py (2 hunks)
Additional context used
Ruff
apps/netsuite/connector.py
1657-1660: Use ternary operator
foreign_amount = 0 if expense.amount == 0 else expense.foreign_amount
instead ofif
-else
-blockReplace
if
-else
-block withforeign_amount = 0 if expense.amount == 0 else expense.foreign_amount
(SIM108)
expense: Expense = Expense.objects.get(pk=line.expense_id) | ||
netsuite_custom_segments = line.netsuite_custom_segments | ||
|
||
if expense.foreign_amount: | ||
if expense.amount == 0: | ||
foreign_amount = 0 | ||
else: | ||
foreign_amount = expense.foreign_amount | ||
else: | ||
foreign_amount = None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor conditional logic for clarity and efficiency.
The changes made to handle the foreign_amount
are logical, but the implementation can be simplified using a ternary operator for better readability and efficiency, as suggested by static analysis.
Replace the if
-else
block with a ternary operator to simplify the assignment of foreign_amount
:
- if expense.foreign_amount:
- if expense.amount == 0:
- foreign_amount = 0
- else:
- foreign_amount = expense.foreign_amount
- else:
- foreign_amount = None
+ foreign_amount = 0 if expense.amount == 0 and expense.foreign_amount else expense.foreign_amount
Committable suggestion was skipped due to low confidence.
Tools
Ruff
1657-1660: Use ternary operator
foreign_amount = 0 if expense.amount == 0 else expense.foreign_amount
instead ofif
-else
-blockReplace
if
-else
-block withforeign_amount = 0 if expense.amount == 0 else expense.foreign_amount
(SIM108)
Co-authored-by: GitHub Actions <integrations@fylehq.com>
Summary by CodeRabbit
New Features
Documentation