Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule #620

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Add submodule #620

merged 4 commits into from
Jul 1, 2024

Conversation

ashwin1111
Copy link
Contributor

@ashwin1111 ashwin1111 commented Jul 1, 2024

Summary by CodeRabbit

  • Chores
    • Updated deployment workflow to fetch full repository history for more comprehensive actions.
  • Documentation
    • Minor formatting updates to the README file.

Copy link

coderabbitai bot commented Jul 1, 2024

Walkthrough

The recent updates involve a minor configuration change and some cosmetic adjustments. Specifically, the .github/workflows/fyle_hulk_deployment.yml file now includes the fetch-depth: 0 option in the actions/checkout@v2 step to allow fetching the entire history during checkout. The README.md file received additional empty lines without affecting any substantive content or functionality.

Changes

Files Change Summary
.github/workflows/fyle_hulk_deployment.yml Added fetch-depth: 0 option to enable full history fetch during checkout.
README.md Added extra empty lines without altering content or logic.

Poem

In the realm of code so bright,
A rabbit hopped, filled with delight.
Fetch-depth zero, history to unfurl,
README pauses, the words did whirl.
Small changes, but progress they bring,
Oh, how the repository sings! 🚀


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jul 1, 2024

Tests Skipped Failures Errors Time
216 0 💤 0 ❌ 0 🔥 25.025s ⏱️

Copy link

github-actions bot commented Jul 1, 2024

Tests Skipped Failures Errors Time
216 0 💤 0 ❌ 0 🔥 25.439s ⏱️

Copy link

github-actions bot commented Jul 1, 2024

Tests Skipped Failures Errors Time
216 0 💤 0 ❌ 0 🔥 25.976s ⏱️

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (14)
README.md (14)

Line range hint 23-23: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 45-45: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```yaml
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 51-51: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 57-57: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 63-63: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 69-69: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 75-75: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 81-81: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 89-89: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 100-100: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 107-107: Specify the language for the code block.

Fenced code blocks should have a language specified to improve readability.

-    ```
+    ```sh
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 61-61: Fix grammatical issues.

There are minor grammatical issues including missing commas, prepositions, and articles.

-    * To tail the logs a service you can do
+    * To tail the logs of a service, you can do
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 79-79: Fix grammatical issues.

There are minor grammatical issues including missing commas, prepositions, and articles.

-    * To run bash inside any container for purpose of debugging do
+    * To run bash inside any container for the purpose of debugging, do
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


Line range hint 87-87: Fix grammatical issues.

There are minor grammatical issues including missing commas, prepositions, and articles.

-    * Add the following environment variables to setup.sh file
+    * Add the following environment variables to the setup.sh file
Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 53481cb and e3a9c87.

Files selected for processing (2)
  • .github/workflows/fyle_hulk_deployment.yml (1 hunks)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/fyle_hulk_deployment.yml
Additional context used
LanguageTool
README.md

[uncategorized] ~61-~61: Possible missing comma found.
Context: ...gres netsuite_db * To tail the logs a service you can do d...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~61-~61: Possible missing preposition found.
Context: ...netsuite_db * To tail the logs a service you can do doc...

(AI_HYDRA_LEO_MISSING_OF)


[uncategorized] ~79-~79: You might be missing the article “the” here.
Context: ... * To run bash inside any container for purpose of debugging do ``` docker-com...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~87-~87: You might be missing the article “the” here.
Context: ... the following environment variables to setup.sh file ``` export API_URL='http:...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

Markdownlint
README.md

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


62-62: Expected: 0 or 2; Actual: 4
Trailing spaces

(MD009, no-trailing-spaces)


84-84: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


12-12: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


13-13: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


23-23: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


1-1: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


11-11: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


97-97: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


107-107: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


22-22: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


45-45: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


51-51: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


57-57: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


63-63: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


69-69: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


75-75: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


81-81: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


89-89: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


100-100: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


107-107: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


113-113: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

Additional comments not posted (1)
README.md (1)

Line range hint 11-13: LGTM!

The submodule setup instructions are clear and correct.

Tools
Markdownlint

8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

Comment on lines +5 to +7



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra blank lines.

Multiple consecutive blank lines are unnecessary and should be removed.

Committable suggestion was skipped due to low confidence.

Tools
Markdownlint

5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

@ashwin1111 ashwin1111 merged commit 4d8f374 into master Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants