-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submodule #620
Add submodule #620
Conversation
WalkthroughThe recent updates involve a minor configuration change and some cosmetic adjustments. Specifically, the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (14)
README.md (14)
Line range hint
23-23
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
45-45
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```yamlTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
51-51
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
57-57
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
63-63
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
69-69
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
75-75
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
81-81
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
89-89
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
100-100
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
107-107
: Specify the language for the code block.Fenced code blocks should have a language specified to improve readability.
- ``` + ```shTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
61-61
: Fix grammatical issues.There are minor grammatical issues including missing commas, prepositions, and articles.
- * To tail the logs a service you can do + * To tail the logs of a service, you can doTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
79-79
: Fix grammatical issues.There are minor grammatical issues including missing commas, prepositions, and articles.
- * To run bash inside any container for purpose of debugging do + * To run bash inside any container for the purpose of debugging, doTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Line range hint
87-87
: Fix grammatical issues.There are minor grammatical issues including missing commas, prepositions, and articles.
- * Add the following environment variables to setup.sh file + * Add the following environment variables to the setup.sh fileTools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/fyle_hulk_deployment.yml (1 hunks)
- README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/fyle_hulk_deployment.yml
Additional context used
LanguageTool
README.md
[uncategorized] ~61-~61: Possible missing comma found.
Context: ...gres netsuite_db* To tail the logs a service you can do
d...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~61-~61: Possible missing preposition found.
Context: ...netsuite_db* To tail the logs a service you can do
doc...(AI_HYDRA_LEO_MISSING_OF)
[uncategorized] ~79-~79: You might be missing the article “the” here.
Context: ... * To run bash inside any container for purpose of debugging do ``` docker-com...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~87-~87: You might be missing the article “the” here.
Context: ... the following environment variables to setup.sh file ``` export API_URL='http:...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Markdownlint
README.md
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
62-62: Expected: 0 or 2; Actual: 4
Trailing spaces(MD009, no-trailing-spaces)
84-84: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
12-12: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
13-13: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
23-23: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
1-1: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
11-11: null
Fenced code blocks should be surrounded by blank lines(MD031, blanks-around-fences)
97-97: null
Fenced code blocks should be surrounded by blank lines(MD031, blanks-around-fences)
107-107: null
Fenced code blocks should be surrounded by blank lines(MD031, blanks-around-fences)
22-22: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
45-45: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
51-51: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
57-57: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
63-63: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
69-69: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
75-75: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
81-81: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
89-89: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
100-100: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
107-107: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
113-113: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Additional comments not posted (1)
README.md (1)
Line range hint
11-13
: LGTM!The submodule setup instructions are clear and correct.
Tools
Markdownlint
8-8: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra blank lines.
Multiple consecutive blank lines are unnecessary and should be removed.
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
5-5: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
6-6: Expected: 1; Actual: 4
Multiple consecutive blank lines(MD012, no-multiple-blanks)
7-7: Expected: 1; Actual: 5
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Summary by CodeRabbit