Skip to content

Commit

Permalink
feat: add missing transfer events (#20)
Browse files Browse the repository at this point in the history
* feat: add solidity events

* feat: add vyper events
  • Loading branch information
banteg committed Jul 25, 2023
1 parent 55e22a6 commit e6d6bc3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions contracts/SolidityVault.sol
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ contract SolidityVault is IERC4626, ERC20 {

_mint(receiver, shares);
emit Deposit(msg.sender, receiver, assets, shares);
emit Transfer(address(0), receiver, shares);

return shares;
}
Expand Down Expand Up @@ -68,6 +69,7 @@ contract SolidityVault is IERC4626, ERC20 {

_mint(receiver, shares);
emit Deposit(msg.sender, receiver, assets, shares);
emit Transfer(address(0), receiver, shares);

return assets;
}
Expand Down Expand Up @@ -103,6 +105,7 @@ contract SolidityVault is IERC4626, ERC20 {

ERC20(asset).transfer(receiver, assets);
emit Withdraw(msg.sender, receiver, owner, assets, shares);
emit Transfer(owner, address(0), shares);

return shares;
}
Expand Down Expand Up @@ -140,6 +143,7 @@ contract SolidityVault is IERC4626, ERC20 {

ERC20(asset).transfer(receiver, assets);
emit Withdraw(msg.sender, receiver, owner, assets, shares);
emit Transfer(owner, address(0), shares);

return assets;
}
Expand Down
4 changes: 4 additions & 0 deletions contracts/VyperVault.vy
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def deposit(assets: uint256, receiver: address=msg.sender) -> uint256:
self.totalSupply += shares
self.balanceOf[receiver] += shares
log Deposit(msg.sender, receiver, assets, shares)
log Transfer(empty(address), receiver, shares)
return shares


Expand Down Expand Up @@ -186,6 +187,7 @@ def mint(shares: uint256, receiver: address=msg.sender) -> uint256:
self.totalSupply += shares
self.balanceOf[receiver] += shares
log Deposit(msg.sender, receiver, assets, shares)
log Transfer(empty(address), receiver, shares)
return assets


Expand Down Expand Up @@ -223,6 +225,7 @@ def withdraw(assets: uint256, receiver: address=msg.sender, owner: address=msg.s

self.asset.transfer(receiver, assets)
log Withdraw(msg.sender, receiver, owner, assets, shares)
log Transfer(owner, empty(address), shares)
return shares


Expand All @@ -249,6 +252,7 @@ def redeem(shares: uint256, receiver: address=msg.sender, owner: address=msg.sen

self.asset.transfer(receiver, assets)
log Withdraw(msg.sender, receiver, owner, assets, shares)
log Transfer(owner, empty(address), shares)
return assets


Expand Down

0 comments on commit e6d6bc3

Please sign in to comment.