Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case when error message is a string. #631

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Handle case when error message is a string. #631

merged 1 commit into from
Jul 18, 2024

Conversation

keunhong
Copy link
Contributor

Fixes #630.

@keunhong keunhong marked this pull request as ready for review July 18, 2024 05:26
@martindurant
Copy link
Member

Thanks for getting this in.

@martindurant martindurant merged commit 5cb4479 into fsspec:main Jul 18, 2024
5 checks passed
@keunhong keunhong deleted the error-is-string branch July 19, 2024 03:07
@keunhong keunhong mentioned this pull request Sep 3, 2024
Open
VOvchinnikov pushed a commit to remerge/gcsfs that referenced this pull request Sep 4, 2024
@keunhong @VOvchinnikov
Handle case when error message is a string. (fsspec#631)
b3cf7b1 
Fixes fsspec#630.
VOvchinnikov pushed a commit to remerge/gcsfs that referenced this pull request Sep 4, 2024
@keunhong @VOvchinnikov
Handle case when error message is a string. (fsspec#631)
fce76ab 
Fixes fsspec#630.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError when error is a string in retry.py
2 participants
@keunhong @martindurant