Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small transaction #586

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

martindurant
Copy link
Member

Fixes #389

It seems return core 499 is new behaviour on GCS upon upload cancel, and not supported on the emulator - so the test does not actually run in CI, but works against real GCS.

Copy link

@jonb377 jonb377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I was able to verify the fix locally. Thanks Martin!

@martindurant martindurant merged commit dd3c7b5 into fsspec:main Oct 6, 2023
5 checks passed
@martindurant martindurant deleted the transaction branch October 6, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading files fails when using transactions
2 participants