Fix account host #480
Merged
Fix account host #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlfs/spec.py
Outdated
| @@ -287,6 +293,7 @@ def __init__( | |||
| ] | |||
| self.location_mode = location_mode | |||
| self.credential = credential | |||
| if account_host: self.account_host = account_host | |||
There was a problem hiding this comment.
This will probably fail our linting on the formatting. You can run either pre-commit run --all-files or black locally to fix that.
adlfs/spec.py
Outdated
| @@ -235,6 +240,7 @@ class AzureBlobFileSystem(AsyncFileSystem): | |||
| def __init__( | |||
| self, | |||
| account_name: str = None, | |||
| account_host: str = None, | |||
There was a problem hiding this comment.
It's unfortunate, but we'll need to put this new parameter at the end. That way we don't break users using positional args AzureBlobFileSystem(account_name, key, ...)
There was a problem hiding this comment.
I made it the last parameter so it doesn't break anything positional.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added account_host parameter to AzureBlobFileSystem, which is needed for package to work in other Azure clouds.