Prepare a mesh for a given geometry. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to distinguish them from regular line strings.
New color handling introduces breaking API changes.
gibbz00
changed the title
frewsxcv
reviewed
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the biggest changes in this PR:
<geometry>_to_mesh()method. Return signature depends on the geometry.build_bevy_meshesand its respective traits are hidden from the public API.PreparedMesh(now calledGeometryMesh) is only returned bygeometry_to_meshorgeometry_collection_to_mesh.Depends on: #8
Being able to ask
geo-bevyto prepare a mesh for a given geometry means that one doesn't have to loop over an iterator and match onPreparedMeshwhen the user knows that only one mesh is returned and which variant it is.This was made possible in #8 due to how line string meshes representing the polygon's exterior and interiors rings are in that PR passed with the
PreparedMesh::Polygonvariant.