Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target kirkwood for Linksys E4200 v2 #389

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

darkdragon-001
Copy link

No description provided.

@darkdragon-001 darkdragon-001 requested review from maurerle and a team as code owners April 1, 2024 18:11
@darkdragon-001 darkdragon-001 force-pushed the target-kirkwood branch 2 times, most recently from 31337d5 to c578356 Compare April 1, 2024 19:08
@grische grische marked this pull request as draft April 1, 2024 19:20
@darkdragon-001 darkdragon-001 force-pushed the target-kirkwood branch 2 times, most recently from 929e060 to 4e926e6 Compare April 1, 2024 19:32
@darkdragon-001
Copy link
Author

@grische The patch should apply cleanly after re-targeting v2023.1.2. Can you trigger the workflow please?

@grische
Copy link
Contributor

grische commented Apr 1, 2024

We usually only add new targets to next. Any particular reason to target stable here?

@darkdragon-001 darkdragon-001 force-pushed the target-kirkwood branch 2 times, most recently from 90dd268 to 37703d9 Compare April 1, 2024 20:34
@darkdragon-001 darkdragon-001 changed the base branch from stable to next April 1, 2024 20:35
@darkdragon-001
Copy link
Author

darkdragon-001 commented Apr 1, 2024

I noticed that I want changes from OpenWrt 23.05, so I target next now.

@GoliathLabs GoliathLabs marked this pull request as ready for review April 1, 2024 22:58
@T0biii
Copy link
Member

T0biii commented Apr 2, 2024

do we need to wait until: freifunk-gluon/gluon#3240 is merged?

@grische
Copy link
Contributor

grische commented Apr 2, 2024

@T0biii not necessarily. If the device works and there's a need for it at FFMuc, we can add it before upstream has support for it.

@darkdragon-001 you do plan to use it with FFMuc don't you?

Btw: you need to push a commit for the ci to trigger after a branch change.
The last build still failed:

2024-04-02T10:37:42.7108862Z WARNING: Makefile 'package/feeds/packages/prometheus-node-exporter-lua/Makefile' has a dependency on 'luci-lib-nixio', which does not exist
2024-04-02T10:37:43.4204303Z make[3]: Leaving directory '/home/runner/work/site-ffm/site-ffm/gluon-build/openwrt'
2024-04-02T10:37:43.4354808Z Error: unable to get default packages for OpenWrt target kirkwood/generic
2024-04-02T10:37:43.4357610Z make[2]: *** [Makefile:179: config] Error 1
2024-04-02T10:37:43.4358842Z make[2]: Leaving directory '/home/runner/work/site-ffm/site-ffm/gluon-build'
2024-04-02T10:37:43.4361285Z make[1]: *** [Makefile:40: build] Error 2
2024-04-02T10:37:43.4362322Z make[1]: Leaving directory '/home/runner/work/site-ffm/site-ffm'
2024-04-02T10:37:43.4363702Z make: *** [Makefile:29: all] Error 2
2024-04-02T10:37:43.4380322Z ##[error]Process completed with exit code 2.

@grische
Copy link
Contributor

grische commented Apr 2, 2024

@darkdragon-001 maybe check this file if this needs modifications for the new target: https://github.com/freifunkMUC/site-ffm/blob/next/image-customization.lua

@darkdragon-001
Copy link
Author

darkdragon-001 commented Apr 3, 2024

@grische Yes, I plan to use this device with FFMuc.

Thanks for the hint, I pushed again after changing the branch. The error should be solved, at least in my fork it builds just fine.

@grische
Copy link
Contributor

grische commented Apr 3, 2024

@darkdragon-001 can you check if the builds in the latest CI run work on your hardware?
https://github.com/freifunkMUC/site-ffm/actions/runs/8534266307?pr=389

@darkdragon-001
Copy link
Author

@grische Just installed it and so far everything seems to work fine.

@grische
Copy link
Contributor

grische commented Apr 3, 2024

@darkdragon-001 great news! Can you give a list of things that are working for you?

@darkdragon-001
Copy link
Author

@grische basically everything I tested. Mostly SSH and AP to FF network.

I cannot test 802.11s as there is no other FF router nearby but I remember having read that this is a hardware limitation anyways.

@grische
Copy link
Contributor

grische commented Apr 3, 2024

If the device doesn't have 802.11s support, I think we should mark it as broken, similar to what you did here:
freifunk-gluon/gluon#3240

Otherwise, I don't see a blocker for merging it.

@darkdragon-001
Copy link
Author

@grische Done.

@grische
Copy link
Contributor

grische commented Apr 3, 2024

From what I can tell you also need to adjust the targets.mk

@darkdragon-001
Copy link
Author

darkdragon-001 commented Apr 3, 2024

@grische Sorry, I can't follow. What do you want me to adjust where?

@grische grische merged commit 0e2a6d6 into freifunkMUC:next Apr 4, 2024
30 checks passed
@darkdragon-001 darkdragon-001 deleted the target-kirkwood branch April 5, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants